SOPHIE: Negative scale value. Setting e_v= nan - Githubissues

mzechmeister / serval

calculate radial velocities from stellar spectra

MIT License

36 stars 9 forks source link

SOPHIE: Negative scale value. Setting e_v= nan #31

Closed mzechmeister closed 4 years ago

mzechmeister commented 4 years ago

The problem goes back to the inplace operation

https://github.com/mzechmeister/serval/blob/2042a70378c15215be4faab6ac3c48f757f4185b/src/inst_SOPHIE.py#L174-L175

This is remember in https://github.com/mzechmeister/serval/blob/2042a70378c15215be4faab6ac3c48f757f4185b/src/inst_SOPHIE.py#L146

And when re-reading the data, the blaze is applied a second time.

mzechmeister commented 4 years ago

The same issue was already fixed in CARM_VIS and CAM_NIR: https://github.com/mzechmeister/serval/commit/e52fcf587bc272d93d7012f9cb735754be7c1d88#diff-30bf2b0a75844236f4d2fb28f7d9f513