NaNs in template tag.fits - Githubissues

mzechmeister / serval

calculate radial velocities from stellar spectra

MIT License

36 stars 9 forks source link

NaNs in template tag.fits #40

Closed mzechmeister closed 3 years ago

mzechmeister commented 3 years ago

Most orders in tag.fits have nans, with exception of one. template.fits is not affected.

Thanks to Evangelos for this report.

mzechmeister commented 3 years ago

The bug was introduced with handling unequal sized orders in

https://github.com/mzechmeister/serval/blob/257a0cf4c34bb6cb0d646468ca62beefc4e5e5aa/src/serval.py#L1306-L1312 https://github.com/mzechmeister/serval/blob/257a0cf4c34bb6cb0d646468ca62beefc4e5e5aa/src/serval.py#L1584