mask Tpl also without vrange - Githubissues

mzechmeister / serval

calculate radial velocities from stellar spectra

MIT License

36 stars 9 forks source link

mask Tpl also without vrange #64

Closed hlruh closed 4 months ago

hlruh commented 4 months ago

Tpl: if vrange is None, an unbroadened mask is returned instead of an empty mask

mzechmeister commented 4 months ago

Reason for the request:

In coadding the created template does not specify a vrange: https://github.com/mzechmeister/serval/blob/57b83582d031816b09f4a2b1dfd65d22567e09a2/src/serval.py#L1890

Thus the msk function of Tpl https://github.com/mzechmeister/serval/blob/57b83582d031816b09f4a2b1dfd65d22567e09a2/src/serval.py#L2077 never masked any knot in the second iteration.

The bko values computed in https://github.com/mzechmeister/serval/blob/57b83582d031816b09f4a2b1dfd65d22567e09a2/src/serval.py#L1817 are no applied.