Closed mzechmeister closed 4 months ago
serval test <(head -5 autolis/J18356+329.lis) -inst CARM_VIS -targ LSRJ1835+3259 -safemode 2 -oset 43:52 -snmin 8 -tpl J02530+168 -look -tplvsini 40
With bug (the badT
mask (magenta) appears to be shifted to the left, see https://github.com/mzechmeister/serval/issues/63#issuecomment-1983880163 for the unbroadened template):
after fix:
https://github.com/mzechmeister/serval/blob/57b83582d031816b09f4a2b1dfd65d22567e09a2/src/serval.py#L222
It should be
self.wk
instead ofwk
, since it might be filtered for finite values in https://github.com/mzechmeister/serval/blob/57b83582d031816b09f4a2b1dfd65d22567e09a2/src/serval.py#L173 or sliced for vsini in https://github.com/mzechmeister/serval/blob/57b83582d031816b09f4a2b1dfd65d22567e09a2/src/serval.py#L191The effect is only obvious for
vsini
option.For regular run, the mask bug did not matter, since there is no broadening and
self.wk
=wk
is ok. Moreover, in the first loop and the spline fitting ofspt
provided only finite values (ii
= full slice): https://github.com/mzechmeister/serval/blob/57b83582d031816b09f4a2b1dfd65d22567e09a2/src/serval.py#L1441 https://github.com/mzechmeister/serval/blob/57b83582d031816b09f4a2b1dfd65d22567e09a2/src/serval.py#L1453In the second loop another hand there is no badT masking (due to absence of
vrange
parameter). See also #64. https://github.com/mzechmeister/serval/blob/57b83582d031816b09f4a2b1dfd65d22567e09a2/src/serval.py#L1890