mzechmeister / viper

GNU General Public License v3.0
5 stars 3 forks source link

viper GUI #46

Closed mzechmeister closed 1 year ago

mzechmeister commented 1 year ago

Ideas/feature requests for viper GUI

JanaKoehler1985 commented 1 year ago

Coming next:

I am also planning to update the Layout of the GUI_vpr.py using the same way as I used now to create GUI_viper.py.

JanaKoehler1985 commented 1 year ago

What do you mean by "group gui: star, cell, tellurics" ?

mzechmeister commented 1 year ago

In viper, options are sorted alphanumerically. I guess this is ok. For the GUI they should be arranged conceptually. It arised during a discussion with Evangelos.

So maybe something like this:

You may consider Tkinter LabelFrame.

JanaKoehler1985 commented 1 year ago

I am open for discussions to re-order things and I am aware not everything is perfect yet. But I am not sure if I like your way of suggested structure. I would prefer it to have the read in of all files together, as well as having all options together. This makes more sense to me.

(Could't have Evangelos came up with this discussion last week as I was visiting you? Would have been much easier to discuss this in person.)

JanaKoehler1985 commented 1 year ago

How about leaving all read in files together, like it is right now, but sort/group the parameters similar to your suggestion? Would that be a compromise?

JanaKoehler1985 commented 1 year ago

I was thinking about order the parameters using (partly) your suggestion and did some tests- see cut-out picture below. Is this what you had in mind? Of cause it is not complete and just should give an idea about how it could look like. But I would like to clarify before changing everything and than may ending up changing it again, if you would prefer it another way.

Bildschirmfoto vom 2023-03-15 15-10-50

mzechmeister commented 1 year ago

Yes, that is what I meant.

Some more comments:

image or as in the old vpr GUI image

JanaKoehler1985 commented 1 year ago

About point 1 and 3: That was the plan ;-) But as said... this was just a little demo test.

Where would you put vcut?

I also prefer the vertical direction. Nevertheless, it is not enough space to put everything in vertical direction. But I could (try to) put two boxes next to each other in horizontal direction and than use the vertical inside the box.

mzechmeister commented 1 year ago

vcut: to Fit parameters or maybe to data next to chunks. Fit parameters -> Fit setup?

JanaKoehler1985 commented 1 year ago

Ok. Nevertheless, can we, as already asked above, agree to keep the reading in of the data and the parameters separated as it is in the current version? I would prefer it this way.

mzechmeister commented 1 year ago

I guess, with "data" you mean also template, cell, and telluric files. Currently, the four search fields at top looks nicely aligned. image But I'm not tied to this. I prefer conceptional grouping. Indeed, tpl and cell files are just model components stored as tables, but they are not data (anymore). Also e.g. tpl file and create tpl should go together and one might expect more parameters.

JanaKoehler1985 commented 1 year ago

I guess, with "data" you mean also template, cell, and telluric files.

Exactly!

Currently, the four search fields at top looks nicely aligned.

I also like it how these fields are nicely aligned at the moment. And I would prefer to keep it like that. Furthermore, in this way it is also easier to create a layout for the rest of the parameters- especially if we prefer vertical direction for parameter inputs.

mzechmeister commented 1 year ago

Well, then go ahead and let's see how it looks.

JanaKoehler1985 commented 1 year ago

I will try to build something that looks the following way. Labelframe names not shown here, but would be: data, template, model, fit parameters, telluric

Bildschirmfoto vom 2023-03-16 14-34-35

mzechmeister commented 1 year ago

Yeah, the GUI looks nice.