Closed mzechmeister closed 4 years ago
The base for the flux polynomial was changed in https://github.com/chamarthisireesha/VIPER/commit/c98b4640507fecb543857a6055795fdc4494120d from ln(lambda) https://github.com/chamarthisireesha/VIPER/blob/4854148bb7ea149ea67ffb7fb93decc6bc5a1828/model.py#L57 to centered pixels https://github.com/chamarthisireesha/VIPER/blob/c98b4640507fecb543857a6055795fdc4494120d/model.py#L60
Using https://github.com/chamarthisireesha/VIPER/tree/ecda1f9c60519b4fbf1471cdd41f7464e90f7148 and this command ./viper.py "data/TLS/hd189733/*" data/TLS/Deconv/HARPS.2006-09-08T02\:12\:38.604_s1d_A.fits -look, the new base give mostly slightly better fits, e.g.
./viper.py "data/TLS/hd189733/*" data/TLS/Deconv/HARPS.2006-09-08T02\:12\:38.604_s1d_A.fits -look
rms values [%] for comparison
n o old new 1 20 1.54 1.50 1 21 1.51 1.50 1 22 1.54 1.53 1 23 1.41 1.39 1 24 1.47 1.47 1 28 1.23 1.19 1 29 1.30 1.24 2 19 1.80 1.75 2 20 1.63 1.57
The base for the flux polynomial was changed in https://github.com/chamarthisireesha/VIPER/commit/c98b4640507fecb543857a6055795fdc4494120d from ln(lambda) https://github.com/chamarthisireesha/VIPER/blob/4854148bb7ea149ea67ffb7fb93decc6bc5a1828/model.py#L57 to centered pixels https://github.com/chamarthisireesha/VIPER/blob/c98b4640507fecb543857a6055795fdc4494120d/model.py#L60
Using https://github.com/chamarthisireesha/VIPER/tree/ecda1f9c60519b4fbf1471cdd41f7464e90f7148 and this command
./viper.py "data/TLS/hd189733/*" data/TLS/Deconv/HARPS.2006-09-08T02\:12\:38.604_s1d_A.fits -look
, the new base give mostly slightly better fits, e.g.rms values [%] for comparison