search

mzgoddard / preact-render-spy

Render preact components with access to the produced virtual dom for testing.
https://www.npmjs.com/package/preact-render-spy
ISC License
178 stars 24 forks source link

Consider a TypeScript version/types definition #27

Closed gnarf closed 7 years ago

gnarf commented 7 years ago

Lots of the preact community seems to be using TypeScript, though I'm unfamiliar with how to do it myself, it would be awesome if we could create the type defs needed for those users!

Hotell commented 7 years ago

Question is, why is this library not written in typed javascript which can generate those type definitions automatically and thus having 100% contract between lib API and type defs :)

gnarf commented 7 years ago

That was the "TypeScript version" part of the issue. I'd be willing to work with someone willing to help make that a reality, but for now, the answer is quite simple: neither of the maintainers know TypeScript 😎

On Jul 10, 2017 17:51, "Martin Hochel" notifications@github.com wrote:

Question is, why is this library not written in typed javascript which can generate those type definitions automatically and thus having 100% contract between lib API and type defs :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mzgoddard/preact-render-spy/issues/27#issuecomment-314260161, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhh6xIFHRUIa3zMCALe3JP5qhfj947kks5sMpzHgaJpZM4ORHNx .

gnarf commented 7 years ago

Closed by #30