search

mzhaom / gperftools

Fast, multi-threaded malloc() and nifty performance analysis tools
https://code.google.com/p/gperftools/
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Add guard around defining WIN32_LEAN_AND_MEAN #124

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
If the embedding project already defines the macro, we get warnings.

A simple fix.

Original issue reported on code.google.com by mbel...@chromium.org on 14 Apr 2009 at 8:03

Attachments:

GoogleCodeExporter commented 9 years ago 
I don't understand -- what embedding project will be #including windows/port.h? 
 Are
you using the code in some way where you don't just compile it as a library?  
port.h
is definitely not meant to be externally exposed!

That said, this seems like good hygiene in any case, so I'm glad to take the 
patch. 
I'm just confused why it's necessary.

Original comment by csilv...@gmail.com on 14 Apr 2009 at 8:32

GoogleCodeExporter commented 9 years ago

Original comment by csilv...@gmail.com on 14 Apr 2009 at 9:23

GoogleCodeExporter commented 9 years ago 
This is fixed in perftools 1.2, just released.

Original comment by csilv...@gmail.com on 18 Apr 2009 at 12:14