Callgrind output should not contain uninteresting frames

[GoogleCodeExporter]

What steps will reproduce the problem?
1. pprof --callgrind 
2. pprof claims "Removing __restore_rt from all stack traces."
3. But a lot __restore_rt is polluting the kcachegrind output

What is the expected output? What do you see instead?

No __restore_rt

What version of the product are you using? On what operating system?

v1.2, cpuprofiling

Please provide any additional information below.

I think it's a bug in pprof. ExtractCalls, which is the basis for callgrind
output only, is performed before RemoveUninterestingFrames. In my opinion,
it should even be performed after Focus and Ignore. A patch for that is
attached.

Original issue reported on code.google.com by weidenri...@gmx.de on 4 Jun 2009 at 2:34

Attachments:

• pprof_patch.txt

[GoogleCodeExporter]

This seems quite plausible to me.  I'm going to pass it by the folks here who 
wrote
the callgrind code originally to see what they think.  Assuming no objections, 
this
will be in the next release.

Original comment by csilv...@gmail.com on 5 Jun 2009 at 3:12

• Changed state: Accepted
• Added labels: Priority-Medium, Type-Defect

[GoogleCodeExporter]

There were no objections, so this will be in the next release.

Original comment by csilv...@gmail.com on 5 Jun 2009 at 5:24

[GoogleCodeExporter]

Original comment by csilv...@gmail.com on 5 Jun 2009 at 8:07

• Changed state: Started

[GoogleCodeExporter]

This should be fixed in perftools 1.3, just released.

Original comment by csilv...@gmail.com on 10 Jun 2009 at 2:05

• Changed state: Fixed