mziech / nextcloud-majordomo

Nextcloud app to sync Majordomo mailing list members with Nextcloud users and groups
GNU Affero General Public License v3.0
3 stars 1 forks source link

Build instructions don't work with docker #21

Closed kolewu closed 2 years ago

kolewu commented 2 years ago

The instructions for building the app with docker, are not working:

npm ERR! missing script: dist

And in fact, there is no build script dist in package.json. Without this I would suspect that the "normal" build will fail, too. I'm even not sure what the docker build should produce: It builds a container with the build result in it (if it succeeds), but how to get to it?

Without a dedicated build script, one could use the node:12 image to build something without installing node and npm on the local machine:

docker run -it --rm -v $(pwd):/work -w /work node:12 \
    bash -c "npm install && npm run build"

Replace npm run build with npm run dist if there is a proper distscript that I think is supposed to create majordomo.tar.gz.

mziech commented 2 years ago

You're right, I removed the dist script while migrating to Github actions and forgot to update the documentation. The tar.gz is now built inside the Github action itself. Also, as you pointed out, the Docker container is not really helpful, I'll remove it and will add something like your example to the README.