Closed kolewu closed 2 years ago
You're right, I removed the dist
script while migrating to Github actions and forgot to update the documentation. The tar.gz is now built inside the Github action itself. Also, as you pointed out, the Docker container is not really helpful, I'll remove it and will add something like your example to the README.
The instructions for building the app with docker, are not working:
And in fact, there is no build script
dist
inpackage.json
. Without this I would suspect that the "normal" build will fail, too. I'm even not sure what the docker build should produce: It builds a container with the build result in it (if it succeeds), but how to get to it?Without a dedicated build script, one could use the
node:12
image to build something without installing node and npm on the local machine:Replace
npm run build
withnpm run dist
if there is a properdist
script that I think is supposed to createmajordomo.tar.gz
.