search

mzimmerm / flutter_charts

Charts Library for Flutter, written in Dart with Flutter.
Other
250 stars 42 forks source link

Fix compile and runtime errors (showing white screen still) #12

Open vijayvepa opened 6 years ago

vijayvepa commented 6 years ago

Fixed errors for Dart 2/ Flutter 0.3.1, but only showing white screen on run, and below message:

I/flutter ( 3663):  ### Size: ui.window.physicalSize=Size(768.0, 1184.0), windowLogicalSize = mediaQueryData.size = Size(384.0, 592.0),chartLogicalSize=Size(384.0, 296.0)
mzimmerm commented 6 years ago

Hi Vijay,

Thanks for the changes, I appreciate this. I have been, for the last few weeks, sitting on my changes migrating to 2.0, which overlap your changes, so I am not sure I will be able to merge this. I committed a subset of my changes yesterday. Your changes look better in some cases, but I also have some additional diffs . Let me commit my changes, and see if that works for you. Some of my changes remove the ability to display int values on the Y axis (show as double), that is partly why I did not commit them all yet. But I will now, if you are using flutter charts with 2.0 compatibility, please let me know if that works for you.

Thanks Milan

vijayvepa commented 6 years ago

Sure, this was only for reference. I could not get it to run anyway.

Thank you, Vijay

On Mon, Apr 30, 2018 at 6:01 PM, Milan Zimmermann notifications@github.com wrote:

Hi Vijay,

Thanks for the changes, I appreciate this. I have been, for the last few weeks, sitting on my changes migrating to 2.0, which overlap your changes, so I am not sure I will be able to merge this. I committed a subset of my changes yesterday. Your changes look better in some cases, but I also have some additional diffs . Let me commit my changes, and see if that works for you. Some of my changes remove the ability to display int values on the Y axis (show as double), that is partly why I did not commit them all yet. But I will now, if you are using flutter charts with 2.0 compatibility, please let me know if that works for you.

Thanks Milan

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mzimmerm/flutter_charts/pull/12#issuecomment-385542169, or mute the thread https://github.com/notifications/unsubscribe-auth/AEvjrFZFmWro4tvze_iJ-jMsOsVOzaz3ks5tt4nQgaJpZM4TrYrQ .

AgainPsychoX commented 5 years ago

So... shouldn't it be closed or somehow dispatched?

vijayvepa commented 5 years ago

Feel free to close it.

Thanks, Vijay

On Wed, Jun 5, 2019 at 6:09 PM Patryk (PsychoX) L. notifications@github.com wrote:

So... shouldn't it be closed or somehow dispatched?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mzimmerm/flutter_charts/pull/12?email_source=notifications&email_token=ABF6HLCBKMXG6LSQHYMUT2TPZA2QZA5CNFSM4E5NRLIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXBFBLY#issuecomment-499273903, or mute the thread https://github.com/notifications/unsubscribe-auth/ABF6HLCL27BNDMYFSOW2AILPZA2QZANCNFSM4E5NRLIA .