search

mzirkof / R-PortFolio

Personnal Profile Project
0 stars 0 forks source link

App's Online version Link #7

Open mzirkof opened 1 year ago

mzirkof commented 1 year ago

:100: Hi. I am happy to show you the online version of my portfolio the link is :

Or copy the URL: https://mzirkof.github.io; and paste it on your web browser :+1:

adel-gu commented 1 year ago

Status: REQUIRED CHANGES ♻️

Hi @mzirkof 👋🏼

Good job so far! 👏🏼👏🏼👏🏼 however, there are some issues that you still need to work on to go to the next project but you are almost there! 💪🏼💪🏼💪🏼.

Highlights

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code.

You can also consider:

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

mzirkof commented 1 year ago

Ok done.

Olamarx commented 1 year ago

Hi @mzirkof,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.