search

mzirkof / R-PortFolio

Personnal Profile Project
0 stars 0 forks source link

Personal Portfolio General Code review #9

Open alyconr opened 1 year ago

alyconr commented 1 year ago

Célestine did a great job, I like the overall structure of the HTML and CSS files, It looks great. It follows the standard HTML and CSS structure with appropriate tags and sections. However, After a deep code review I will highlight the most important to keep in mind:

Sections I like how He includes several sections elements to divide the content into meaningful sections, such as headline, recent works, about me, form, and footer, this totally helps in organizing the content of the page.

Semantic Markup While most of the markup is adequate, there are a few areas where semantic tags could be used for better clarity. For example, consider using <main> instead of <div class="main"> to represent the main content of the page, and use <footer> for the footer section instead of a generic <section>.

Accessibility Accessibility is an essential aspect of web development. Make sure to include appropriate alternative text (alt attributes) for images, especially in the social media links and icons. This helps visually impaired users and improves SEO.

Overall, The project is awesome, great way to organize and structure the application code.

mzirkof commented 1 year ago

@alyconr Thanks for the review. I will put into practice the good advice