mzp / LoveLiver

Create Apple's Live Photos from JPEG and MOV.
MIT License
379 stars 28 forks source link

Add exifversion to the live photo jpeg file #18

Closed paraselene closed 6 years ago

paraselene commented 6 years ago

For uploading live photo to Facebook, you need the exifversion to make it works in Facebook.

banjun commented 6 years ago

@paraselene Thank you for PR 👍 It would be nice to be with Facebook sharing compatibility. I want to know some detail for the live photo support in Facebook, and, what you have tried to do to make it.

Could you post a comment explaining that like below?

paraselene commented 6 years ago

Steps to upload live photo (usecase)

  1. Create Live Photo using LoveLiver
  2. Import the Live Photo to Mac Photo App
  3. Send the Live Photo to iPhone using AirDrop in Photo App
  4. Upload the Live Photo to Facebook

Actual Result

Live Photo doesn't work in Facebook img_0196 Live Photo Icon disappears after expanding the Live Photo to full screen img_0198

Expected Result

After adding exifVersion, Live Photo works in Facebook img_0197 Live Photo Icon still exists there after expanding the Live Photo to full screen img_0199

banjun commented 6 years ago

great results 💓 I will check the behavior, merge and release later in this weekend.