Add CONTRIBUTING.md explaining how to run the tests

mzuccaroli / angular-google-tag-manager

A service library for integrate google tag manager in your angular project

https://itnext.io/how-to-add-google-tag-manager-to-an-angular-application-fc68624386e2

MIT License

138 stars 78 forks source link

Add CONTRIBUTING.md explaining how to run the tests #128

Open duvet86 opened 2 years ago

duvet86 commented 2 years ago

Hello and thanks for the library.

My team and I would like to submit a PR to enable dynamic configuration, similar to what auth0 does with their angular-sdk.

Can you please include a CONTRIBUTING.md explaining how to run the tests. Because apparently the tests fail if I am not replacing the TEST_GTM_ID with a valid key. Is that expected?

Thank you, Luca

duvet86 commented 2 years ago

bump, or we will have to fork it and create a different package.

mzuccaroli commented 2 years ago

Sorry for being late , I'm the only mantainer and I'm busy. While i work on a official CONTRIBUTING.md, I think this is not an expected behavior.

Generally, as you can se, the unit tests are quite small and not updated. I found that the only reliable test are tricky and manual: you need to build the lib, copy the build artifacts in the "node_modules/angular-google-tag-manager/" folder of the demo application and tun it with a real GTM ID.

duvet86 commented 2 years ago

Grazie Marco, sorry for pushing you. I'll submit a PR with the dynamic config very soon.

Thanks for your work, Luca