Null-Like GTM-ID should not throw an error

[ma7moudat]

Background:

• Our project (much like many others) has different settings for DEV and PROD. We want GTM only for PROD.
• The GoogleTagManagerModule can not be imported conditionally (on for PROD, off for DEV).
• Providing a null-like value (empty string, null, undefined) for googleTagManagerId causes an error and breaks the whole application.

This doesn't make much sense, since GTM is not a crucial piece of code and the project should be able to run without it. Kind of an opt-in feature.

This means, when the settings are not valid, an error should not be thrown; maybe just a console warning instead hinting to the facts that tags can't be pushed.

[AElmoznino]

Struggling with the same issue here, +1!

[cmalard]

works fine with empty string ;-) BUT the tags will still be fired (and will respond with an HTTP 400 😂 👌)

Would be awesome to still have the Angular service (to not break existing calls) but not load the google-tag-manager lib nor trigger the API calls 🙇 In the meantime, we added checks to see if this.gtmService.googleTagManagerId is valid to trigger or not the pushTag

[pm20390]

Hey there, can you check out if the PR fixes this? We had a similar issue and this was a good solution.