search

mzuccaroli / angular-google-tag-manager

A service library for integrate google tag manager in your angular project
https://itnext.io/how-to-add-google-tag-manager-to-an-angular-application-fc68624386e2
MIT License
136 stars 78 forks source link

silent mode and #171 fix #178

Closed pm20390 closed 1 year ago

pm20390 commented 1 year ago

Fix https://github.com/mzuccaroli/angular-google-tag-manager/issues/171 where the public-api was missing an export.

Added a feature my team needed that I've called "silent mode", where instead of throwing an error when the GTM id is null, it will simply return false. This is especially useful for dynamically loaded GTM ids that may not always be available or valid. It looks for an injection token "googleTagManagerMode" specified as "silent" or "noisy" (defaults to "noisy") to determine the behavior.

"Silent mode" fixes https://github.com/mzuccaroli/angular-google-tag-manager/issues/158 as well I believe.

pm20390 commented 1 year ago

@mzuccaroli here is the updated PR with the fork existing this time :)

mzuccaroli commented 1 year ago

Hi @pm20390 sorry for my absence but I was very busy, I merged your PM in the develop branch can you help me by testing this branch so I can release the 1.7.1 version?

pm20390 commented 1 year ago

@mzuccaroli sure, no prob

pm20390 commented 1 year ago

are there any specific tests you need or just check it out and let you know that its ok?

mzuccaroli commented 1 year ago

check it out, I have not created consistent test plans