search

mzuccaroli / angular-google-tag-manager

A service library for integrate google tag manager in your angular project
https://itnext.io/how-to-add-google-tag-manager-to-an-angular-application-fc68624386e2
MIT License
136 stars 78 forks source link

feature: Angular 18 support #198

Closed guillaume-moreau closed 1 month ago

guillaume-moreau commented 1 month ago

Hi @mzuccaroli

This PR is for #197

What I did:

Other modification suggested:

While updating I've some deprecated libraries used and a unit test where the expectation is never reached.

I want to keep this PR light and don't want it to be blocked because of some refactoring stuff, so I've created branches on my fork. They all are based on this Angular 18 migration PR, so if you are OK after this branch is merged I can put those 3 PR.

Remove protractor https://github.com/guillaume-moreau/angular-google-tag-manager/tree/feature/remove-protractor

Replace codelyzer by eslint https://github.com/guillaume-moreau/angular-google-tag-manager/tree/feature/replace-codelyzer

Test with expectation never reached https://github.com/guillaume-moreau/angular-google-tag-manager/tree/feature/test-without-expectation

I'm available for any suggestion/remarks !

Thank you :)

mzuccaroli commented 1 month ago

thank you @guillaume-moreau , PR has been merged and the library has been published , feel free to create pr for your other branches, your contributions are welcome!