search

mzur / gnome-shell-wsmatrix

GNOME shell extension to arrange workspaces in a two-dimensional grid with workspace thumbnails
GNU General Public License v3.0
458 stars 58 forks source link

Fix reset/destroy of workspace thumbnails in overview #180

Open mzur opened 2 years ago

mzur commented 2 years ago

The workspace thumbnails in the overview are not reset if the extension is disabled, then enabled again and then "Show workspace grid in overview" is switched off. They still show the wallpaper. They also don't reset if the whole extension is disabled in this case.

ebeem commented 2 years ago

I would consider this a feature myself :grin: I wonder why they removed it actually.

This doesn't seem to be a bug in the overriding/restoring part. The thumbnail boxes just need to be reconstructed as they are kept even after restoring. I am not sure how we can force GNOME to reconstruct the thumbnail boxes but if you try to add more workspaces (let's say add one row), you will notice the new workspaces added will have no wallpaper.

So we just need to figure out a way to reconstruct the thumbnail boxes here. https://github.com/mzur/gnome-shell-wsmatrix/blob/64c3895c0507718bf5a77ac2a04cabb3e793fbba/wsmatrix%40martin.zurowietz.de/overview/thumbnailsBox.js#L303-L305