search

mzur / gnome-shell-wsmatrix

GNOME shell extension to arrange workspaces in a two-dimensional grid with workspace thumbnails
GNU General Public License v3.0
458 stars 58 forks source link

Fix style of popup if thumbnails are disabled #182

Open mzur opened 2 years ago

mzur commented 2 years ago

The switcher popup without thumbnails should have the same style/look than the default switcher popup.

ebeem commented 2 years ago

Is it different? it should be exactly the same now, they use the same code.

mzur commented 2 years ago

Default switcher: image

Wsmatrix: image

ebeem commented 2 years ago

oh, this is going to be quite hard. wsmatrix now extends SwitcherPopup instead of WorkspaceSwitcherPopup both parents extend St.Widget, but each has its own way of constructing the popup.

I tried to just bring back the style classes from WorkspaceSwitcherPopup but that showed a very bad style and the indicator wasn't even visible. Maybe we will need to look more into this but I think it's low priority issue. The only thing here is that wsmatrix will get the style from other switchers like the app switcher rather than the workspaces switcher. This actually helped us a lot because theme developers take into account the app switcher which shows icons of the app (similar to thumbnails), but never take into consideration the possibility of thumbnails existing in the WorkspaceSwitcherPopup which caused the usability styling issues we had with some themes.

In case we need to get this back, I suggest we keep trying having one switcher popup class for both with or without thumbnails.

mzur commented 2 years ago

GNOME 42 uses a new switcher popup style with dots at the bottom. I'd like to use this style for our popup without thumbnails (if someone is willing to implement it).