search

mzur / gnome-shell-wsmatrix

GNOME shell extension to arrange workspaces in a two-dimensional grid with workspace thumbnails
GNU General Public License v3.0
458 stars 58 forks source link

Configurable color of active workspace indicator #226

Open soccercheng opened 2 years ago

soccercheng commented 2 years ago

The current color setting of of active workspace, on Ubuntu 22.04, when switching workspace using Ctrl + left/right key is not so clear, please change the current color settings using more contrasting color(s).

guidov commented 2 years ago

What about having the option to control the color settings in the gnome extension settings accessed from the gnome extensions page? I don't want to ask too much, really appreaciate the work that went into this, it is an indespensible tool, thanks.

ebeem commented 2 years ago

please take a look at issue #12

I believe it's a bit similar, now to describe this problem quickly, I think you're using a custom gnome-shell theme? wsmatrix inherits the shell theme, so it should respect the light/dark theme and look and feel of your gnome-shell setup.

The problem with contrast is that some gnome-shell themes don't style some components properly, check this example. One good suggestion by @mzur was to inherit the window application popup instead (it's usually styled better by gnome-shell themes developers as it's an important component of gnome-shell). Since gnome-40, wsmatrix inherits the window application popup look and feel which should fix most styling issues. However, this doesn't mean that the problem is solved due to poor gnome-shell theme color schemes. The only way to solve this issue is to create something like this so users can override some theme options.

I am personally a supporter of having this styling option, but it will need some effort to implement properly. Unfortunately, there are higher priority bugs now (mostly related to upstream, but we need to take care of it)

mzur commented 2 years ago

Any volunteers are welcome to send a PR for this.

souperk commented 1 year ago

I got a workaround for anyone interested.

Create the file ~/.local/share/gnome-shell/extensions/wsmatrix@martin.zurowietz.de/stylesheet.css and add

.item-box:selected {
    background-color: lightblue;
}

You can replace lightblue with any html (or rgb) color of your choise. I do not know the restrictions for CSS with gnome shell extensions but you can experiment with borders etc. In order to test the change, simply logout and log back in again (works for wayland).

rambit commented 1 year ago

Workaround is good, but file gets deleted on every extension update.

To whoever works on a PR, I see that mzur's other plugin seems to include a GtkColorButton in settings.ui