mzur / gnome-shell-wsmatrix

GNOME shell extension to arrange workspaces in a two-dimensional grid with workspace thumbnails
GNU General Public License v3.0
469 stars 60 forks source link

GNOME: add support for version 44 #251

Closed matttbe closed 1 year ago

matttbe commented 1 year ago

First, thank you for maintaining this very useful add-on!

When using GNOME 44 beta (44~beta-1ubuntu1 on Ubuntu 23.04), I got this warning after having forced version 44 support in metadata.js:

JS ERROR: TypeError: Meta.later_add is not a function
vfunc_allocate@${HOME}/.local/share/gnome-shell/extensions/wsmatrix@martin.zurowietz.de/overview/thumbnailsBox.js:187:26
vfunc_allocate@resource:///org/gnome/shell/ui/overviewControls.js:195:40
_prepareMainDash/<@/usr/share/gnome-shell/extensions/ubuntu-dock@ubuntu.com/docking.js:2264:22
_hideDone@resource:///org/gnome/shell/ui/overview.js:632:25
_animateNotVisible/<@resource:///org/gnome/shell/ui/overview.js:625:55
onStopped@resource:///org/gnome/shell/ui/overviewControls.js:771:21
_makeEaseCallback/<@resource:///org/gnome/shell/ui/environment.js:151:22
_easeActorProperty/<@resource:///org/gnome/shell/ui/environment.js:317:60

I simply applied the same fix as this one: https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/8d68bdaaa163

I guess this modification breaks the compatibility with older versions but I didn't investigate more.

Apart from that, the rest seems working fine, tested on Wayland only.

tjaalton commented 1 year ago

Thanks! This works here.

mzur commented 1 year ago

Thanks, I'll test this once GNOME 44 is available in my Arch VM.

icegood commented 1 year ago

works great under ubuntu 23.04/x11

mzur commented 1 year ago

Alright. While I couldn't test it myself so far, I'll trust your reports and merge.

tstirrat15 commented 1 year ago

This worked for me as well on 23.04 with wayland. Thank you!