search

mzur / gnome-shell-wsmatrix

GNOME shell extension to arrange workspaces in a two-dimensional grid with workspace thumbnails
GNU General Public License v3.0
469 stars 60 forks source link

Support for gnome 47 #286

Closed andersjohansson closed 1 month ago

andersjohansson commented 2 months ago

In my testing there doesn't seem to be any breaking changes for gnome 47, so just updating the stated supported version just worked. But it would of course be useful if someone else tested this.

skoume commented 2 months ago

There is breakage due to changes in spacing.

If you have "Show workspace grid in overview" option enabled you don't get workspace previews or app icons just a grey empty area.

spacing needs to be added as a parameter to _computeWorkspacesBoxForState in controlsManagerLayout.js and references to this._spacing replaced with the parameter spacing.

EDIT: I have made the changes on my pc and they work on gnome 47 but I suppose they would in turn break in previous gnome versions ?

mzur commented 1 month ago

@andersjohansson Thanks a lot!

@skoume A breaking change is no problem. Please post the required changes here (or open a new PR against this one).

I'll look at it as soon as I can.

skoume commented 1 month ago

@mzur Hello, I think I made a new pull request, not sure how I could make it against/associated with this one.

I also do not actually change the supported version I just fix the grey screen issue.

andersjohansson commented 1 month ago

Great @skoume! I missed this (since I don’t use the overview much).

I included your changes and updated the compatibility metadata in this branch. It works well on gnome47 for. If it works for others I think this could be merged.

przepompownia commented 1 month ago

Works for me, thanks!

taotriad commented 1 month ago

I can confirm that these changes works for me too.

lelledaniele commented 1 month ago

Works for me on Ubuntu 24.10 Thanks

tstirrat15 commented 1 month ago

What's the timeline for merge on this?

baldarn commented 1 month ago

here on tumbleweed, this extension is broken :/

mzur commented 1 month ago

Thanks everyone! Usually I test new versions and check for additional code changes in GNOME Shell but this time I just don't have the time. Since so many of you tested this already I just assume that everything is fine.

mzur commented 1 month ago

@baldarn Please open a new issue with more information (such as error messages from the logfile).

baldarn commented 1 month ago

here on tumbleweed, this extension is broken :/

@baldarn Please open a new issue with more information (such as error messages from the logfile).

after latest update it works, thanks!