mzur / gnome-shell-wsmatrix

GNOME shell extension to arrange workspaces in a two-dimensional grid with workspace thumbnails
GNU General Public License v3.0
467 stars 59 forks source link

Support multi-monitor setups #49

Closed ebeem closed 5 years ago

ebeem commented 5 years ago

related to #21 and #46

this was discussed before, but due to the many changes that have been implemented since the previous PR, it needed to be done again. the problems that were listed before are

regarding point#1, I tried my best to keep the code as simple as possible. making GNOME properly show thumbnails of workspaces is easy, but it will require more rewriting of methods from the class WorkspaceThumbnail.

I have been trying this for days, and it seems fine. However, I will feel more comfortable if anyone who is interested can test it as well.

mzur commented 5 years ago

Current method seems to work fine, but it's probably going to cause conflicts with some extensions or cause some bugs at some point (best solution is to have GNOME support getting thumbnails from a specific monitor and workspace).

Do you mean the workaround with Main.layoutManager.primaryIndex in the WorkspaceThumbnail class or anything else?

I'll see if I can test this. I only have a VM for the newer versions of GNOME and I don't know if I can set it up for multiple monitors.

ebeem commented 5 years ago

yes, it's this part about changing the primary index and then restoring it after getting the thumbnail

mzur commented 5 years ago

I found that it's super easy to emulate multiple monitors with a VM. I'll have a look at this in the next few days.

ebeem commented 5 years ago

Great job!! thanks. regarding the GNOME 3.34 update, I have tested the extension under GNOME 3.33.91 and it's working fine until now.

mzur commented 5 years ago

@ebeem Will you merge this? Are you even able to? :smile: I don't know what permissions you have got as collaborator in this repo.

ebeem commented 5 years ago

yes, I was able to merge 😆