mzweilin / EvadeML-Zoo

Benchmarking and Visualization Tool for Adversarial Machine Learning
https://evadeML.org/zoo
MIT License
186 stars 63 forks source link

Add SVHN #1

Closed fqdhlyc closed 5 years ago

fqdhlyc commented 6 years ago

Add SVHN dataset, as well as implementing carlini attack on SVHN dataset.

mzweilin commented 6 years ago

Hi @fqdhlyc , thanks a bunch for the code contribution! Before I merge your pull request into the master branch, could you please make these quick fixes?

  1. Remove the temporary files with the suffix ~;
  2. Add a command line for downloading your pre-trained SVHN model;
  3. Make sure the example usage in README.md is runnable if we replace "MNIST" with "SVHN".

Best,

fqdhlyc commented 6 years ago

Hi Weilin,

I will make these changes as soon as I get a chance, thanks!

-Yuancheng Lin


From: Weilin Xu notifications@github.com Sent: Tuesday, August 28, 2018 10:21:41 PM To: mzweilin/EvadeML-Zoo Cc: fqdhlyc; Mention Subject: Re: [mzweilin/EvadeML-Zoo] Add SVHN (#1)

Hi @fqdhlychttps://github.com/fqdhlyc , thanks a bunch for the code contribution! Before I merge your pull request into the master branch, could you please make these quick fixes?

  1. Remove the temporary files with the suffix ~;
  2. Add a command line for downloading your pre-trained SVHN model;
  3. Make sure the example usage in README.md is runnable if we replace "MNIST" with "SVHN".

Best,

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/mzweilin/EvadeML-Zoo/pull/1#issuecomment-416801543, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AgDVQ20FKHWIucnM13pbO07copqO79xdks5uVfq1gaJpZM4WDKi2.

evansuva commented 5 years ago

Is this ready to merge now?

fqdhlyc commented 5 years ago

For 1. Done

  1. For downloading pre-trained model download, I was thinking to include in https://github.com/mzweilin/EvadeML-Zoo/releases/download/v0.1/downloads.tar.gz so that it is for users to download all models at once.

  2. Will work if replace MNIST with SVHN, and model to tohinz. It will produce similar result like CIFAR10 with carlini model.

mzweilin commented 5 years ago

For 1. Done

  1. For downloading pre-trained model download, I was thinking to include in https://github.com/mzweilin/EvadeML-Zoo/releases/download/v0.1/downloads.tar.gz so that it is for users to download all models at once.
  2. Will work if replace MNIST with SVHN, and model to tohinz. It will produce similar result like CIFAR10 with carlini model.

Could you provide the trained model so that I can integrate it into our downloads tarball?

fqdhlyc commented 5 years ago

Please check your school email, thanks.


From: Weilin Xu notifications@github.com Sent: Saturday, December 29, 2018 1:02:59 PM To: mzweilin/EvadeML-Zoo Cc: fqdhlyc; Mention Subject: Re: [mzweilin/EvadeML-Zoo] Add SVHN (#1)

For 1. Done

  1. For downloading pre-trained model download, I was thinking to include in https://github.com/mzweilin/EvadeML-Zoo/releases/download/v0.1/downloads.tar.gz so that it is for users to download all models at once.
  2. Will work if replace MNIST with SVHN, and model to tohinz. It will produce similar result like CIFAR10 with carlini model.

Could you provide the trained model so that I can integrate it into our downloads tarball?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/mzweilin/EvadeML-Zoo/pull/1#issuecomment-450509766, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AgDVQzW3idhfsRj2aVIjLy44V6E_Pv51ks5u965TgaJpZM4WDKi2.