search

mzxrules / MasterOcarina

Collection of Zelda 64 programs
12 stars 6 forks source link

MM crashes #1

Closed Rus3545 closed 5 years ago

Rus3545 commented 5 years ago

Hi. This release: link for "mm J1, P0, P1, GCJ, GCU, GCP, DBG" don't working.

Path updated! Re-run program to continue Initializing task list: Unhandled Exception: System.ArgumentOutOfRangeException: Non-negative number required. Parameter name: value at System.IO.MemoryStream.set_Position(Int64 value) at mzxrules.OcaLib.VFileTable.GetOverlayRecord(Int32 index, Type type) in C:\Users\mzxrules\Google Drive\Documents\Visual Studio 2013\Projects\Projects\MasterOcarina\OcaLib\source\Rom\VFileTable.cs:line 319 at Atom.DisassemblyTask.CreateTaskList(Rom rom) in C:\Users\mzxrules\Google Drive\Documents\Visual Studio 2013\Projects\Projects\MasterOcarina\Atom\DisassemblyTask.cs:line 204 at Atom.Atom.DisassembleRom(RomVersion ver, String path) in C:\Users\mzxrules\Google Drive\Documents\Visual Studio 2013\Projects\Projects\MasterOcarina\Atom\program.cs:line 260 at Atom.Atom.Main(String[] a) in C:\Users\mzxrules\Google Drive\Documents\Visual Studio 2013\Projects\Projects\MasterOcarina\Atom\program.cs:line 100

Exemples bases: link My spreadsheets "ods" for help, see and use "help" and "script": link Thank you.

Rus3545 commented 5 years ago

I saw that something had changed, tried to compile ... I could not. ( I got to these errors:

FileAddress.cs(31,28): error CS1001 FileAddress.cs(31,49): error CS1002 FileAddress.cs(31,53): error CS1519 FileAddress.cs(34,19): error CS1519 FileAddress.cs(34,31): error CS1519 FileAddress.cs(35,17): error CS1519 FileAddress.cs(35,27): error CS1519 FileAddress.cs(38,16): error CS1520 FileAddress.cs(50,52): error CS1019 FileAddress.cs(50,53): error CS1001 FileAddress.cs(50,74): error CS1002 FileAddress.cs(50,74): error CS0116 FileAddress.cs(50,78): error CS1022 FileAddress.cs(52,24): error CS1520 FileAddress.cs(52,40): error CS1001 FileAddress.cs(79,5): error CS1022 FileAddress.cs(80,1): error CS1022 Endian.cs(200,25): error CS1525 Endian.cs(200,31): error CS1003 Endian.cs(201,25): error CS1525 Endian.cs(201,31): error CS1003 Endian.cs(202,25): error CS1525 Endian.cs(202,31): error CS1003 Endian.cs(208,25): error CS1525 Endian.cs(208,32): error CS1003 Endian.cs(209,25): error CS1525 Endian.cs(209,32): error CS1003 Endian.cs(210,25): error CS1525 Endian.cs(210,32): error CS1003 Endian.cs(216,25): error CS1525 Endian.cs(216,30): error CS1003 Yaz.cs(55,29): error CS1525 Yaz.cs(55,34): error CS0443 Yaz.cs(55,36): error CS1003 Yaz.cs(411,29): error CS1528 Yaz.cs(411,29): error CS1003 Yaz.cs(411,30): error CS1525 Yaz.cs(411,35): error CS0443 Yaz.cs(411,37): error CS1026 Yaz.cs(411,37): error CS1003 Yaz.cs(411,42): error CS1003 Yaz.cs(411,42): error CS1002 Yaz.cs(411,42): error CS1513 Yaz0.cs(54,29): error CS1525 Yaz0.cs(54,34): error CS0443 Yaz0.cs(54,36): error CS1003 Endian.cs(217,25): error CS1525 Endian.cs(217,30): error CS1003 Endian.cs(218,25): error CS1525 Endian.cs(218,30): error CS1003 Endian.cs(223,25): error CS1525 Endian.cs(223,29): error CS1003 Endian.cs(224,25): error CS1525 Endian.cs(224,29): error CS1003 Endian.cs(225,25): error CS1525 Endian.cs(225,29): error CS1003 N64Ptr.cs(104,52): error CS1026 N64Ptr.cs(104,52): error CS1002 N64Ptr.cs(104,57): error CS1002 N64Ptr.cs(104,57): error CS1513 N64Ptr.cs(105,45): error CS1002

Is it something wrong with me or is the code just raw yet? I used MS Build Tools 2015(14.0) + NDP472-DevPack or ndp48-devpack for Win7x64.

I saw Yaz.cs in the report. Therefore, I will add a little more information, it will come in handy. The absolutely accurate Yaz algorithm for N64 implemented by Zoinkity for Python "Nintendo.py":link It has been ported to C# onepiecefreak3, Little Endian option is just not needed: link The fastest algorithm implemented by dnasdw for C++: link N64 and GC Yaz are slightly different in compression ratio and speed...

mzxrules commented 5 years ago

It's failing to compile because Helper uses .net standard 2.0 i believe. I don't think MS Build Tools 2015 supports the .net standard

Rus3545 commented 5 years ago

Ok. MS Build Tools 2017(15.0) + dotnet-sdk-2.2.109-win-x64 + dancing with a tambourine (like: dotnet restore Atom\Atom.csproj; MSBuildSDKsPath e,t,c) and the compilation goes successful. But "mm DBG" test still fails:

Path updated! Re-run program to continue Initializing task list: Unhandled Exception: System.ArgumentOutOfRangeException: Non-negative number required. Parameter name: value at System.IO.MemoryStream.set_Position(Int64 value) at mzxrules.OcaLib.VFileTable.GetOverlayRecord(Int32 index, Type type) in e:\Ma sterOcarina\OcaLib\Rom\VFileTable.cs:line 311 at Atom.DisassemblyTask.CreateTaskList(Rom rom) in e:\MasterOcarina\Atom\Disass emblyTask.cs:line 205 at Atom.Atom.DisassembleRom(RomVersion ver, String path) in e:\MasterOcarina\At om\program.cs:line 260 at Atom.Atom.Main(String[] a) in e:\MasterOcarina\Atom\program.cs:line 100

Thanks again. I will follow the updates. Hopefully fixed someday...

mzxrules commented 5 years ago

Think i figured out the issue. TransitionTable_Start was undefined in Addresses.xml for a number of MM versions. You should be able to fix this without recompiling the program by editing the /data/Addresses.xml file and changing the node to this: 

        <Address reftype="absolute" domain="ROM">
          <Data ver="J0">C82CD0</Data>
          <Data ver="J1">C82FA0</Data>
          <Data ver="U0">C670F0</Data>
          <Data ver="P0">DAD390</Data>
          <Data ver="P1">DAD4B0</Data>
          <Data ver="GCJ">C6EA00</Data>
          <Data ver="GCU">C749F0</Data>
          <Data ver="GCP">DBA4B0</Data>
          <Data ver="DBG">DF0600</Data>
        </Address>
      </Identifier>
Rus3545 commented 5 years ago

Yep, this issue can be closed. P.S: It really improves extensibility, detection and correction of variables errors. Atom 18-12-18 only the base was allowed to change and definitely out of date....