search

n-apps / ScoreCounter

Android app. Score Counter will help you easily keep score in any games, sports or other activities. Will do all the math for tracking initiative, HP, hit points, spell slots or even count win streaks in your bar game night!
GNU General Public License v3.0
70 stars 19 forks source link

A confirmation dialog #15

Closed PeterCeresnik closed 5 years ago

PeterCeresnik commented 5 years ago

Hi, I added confirmation dialog when clicking on Remove all (and also on Reset all) as it was one of the listed issues. Translation into different languages than English are needed to be added.

n-apps commented 5 years ago

@PeterCeresnik as for me, it's possible to add this feature in the CountersFragment itself, without calling listener from MainActivity. Second, analytic events should be called after option menu was clicked, not after action was confirmed.

PeterCeresnik commented 5 years ago

I moved dialog implementation from MainActivity to CountersFragmet. Still, I kept listener, so the code could be reusable as it is used twice in this fragment. Also analytic event was moved before dialog. I committed changes.

PeterCeresnik commented 5 years ago

I made changes you mentioned.