search

n-apps / ScoreCounter

Android app. Score Counter will help you easily keep score in any games, sports or other activities. Will do all the math for tracking initiative, HP, hit points, spell slots or even count win streaks in your bar game night!
GNU General Public License v3.0
70 stars 19 forks source link

Implement dark mode (Android 10+) #35

Closed n-apps closed 4 years ago

n-apps commented 5 years ago

https://arturdryomov.online/posts/midnight-in-android-themes/

vabene1111 commented 5 years ago

maybe, when implementing this feature, one could also slightly change the dark mode colors to better fit with the default dark color theme (e.g. instead of black some grey-ish colors and so on).

I am no design expert and the current version is fine, but maybe it looks better

n-apps commented 5 years ago

Definitely will update dark mode colors. Thanks for suggestion 😉

vabene1111 commented 5 years ago

i am currently working on implementing the necessary changes. What i am unsure about right now is if we want the user to still have the choice to override the dark mode settings in the app or if we just want to use the system settings. What do you think ?

Here is the branch i am working on, not much there yet but .. https://github.com/vabene1111/ScoreCounter/tree/feature/android_q_night

vabene1111 commented 5 years ago

Currently the new dark colors look like this, the colors.xml is cleaned up a little so the same ressource names are used for dark and ligth theme (makes changes much easier).

2019-09-24_15-04_Android_Emulator_-_Pixel_3_API_295554 2019-09-24_15-08_Android_Emulator_-_Pixel_3_API_295554 (2) 2019-09-24_15-08_Android_Emulator_-_Pixel_3_API_295554
n-apps commented 5 years ago

I think, better to use the system settings on Android ≥ Q and hide the switch

vabene1111 commented 5 years ago

ok then i will just implement a little piece of hiding code, i prefer this way as well!