search

n-apps / ScoreCounter

Android app. Score Counter will help you easily keep score in any games, sports or other activities. Will do all the math for tracking initiative, HP, hit points, spell slots or even count win streaks in your bar game night!
GNU General Public License v3.0
70 stars 19 forks source link

The third button on the dice setting has a string crop out. It should be "D20", I believe. #68

Closed n-apps closed 4 years ago

n-apps commented 4 years ago

Device: Galaxy S8 OS: Android 9 Screen Resolution: 1480×720 Minimum width set in developers settings: 360dp (default)

vabene1111 commented 4 years ago

i have tried changing the android:elipsize https://developer.android.com/reference/android/widget/TextView#attr_android:ellipsize property but it does not seem to have an effect on the buttons. I have also tried to change the paddings to the right and left of the text boxes to be a little smaller but it did not have an effect either (my android skills are a little rusty i guess).

One simple solution would be to use a little smaller margin to the right and left of the selection as shown in the screenshot below (left original, right smaller margin). There might still be devices where even this is to small but they will probably require a completly different solution.

image

if you like the change i will open a PR next week

n-apps commented 4 years ago

(my android skills are a little rusty i guess). nope, this is widget from fresh Google lib, so everything can be broken (I literally issued a bug seconds ago) :)

I like solution with margins 👍‍‍