search

n-b / Bicyclette

La meilleure appli Vélib
http://bicyclette-app.fr
BSD 2-Clause "Simplified" License
47 stars 12 forks source link

Station incorrectly placed on map (Orléans) #97

Closed bertrand-lupart closed 7 years ago

bertrand-lupart commented 7 years ago

At least one station in Orléans is incorrectly placed on the map (will check others).

Not sure how to correct this.

n-b commented 7 years ago

Hi Bertrand,

the app fetches data from the Orléans bikesharing webservices, including the stations location, so I’m afraid there’s not much I can do by myself. Which station is this exactly?

n-b commented 7 years ago

By the way: I realize you don’t really care about it, but this repo doesn’t reflect the current state of the app, at all. For various reasons, I couldn’t publish the source anymore for some time. I need to reopen it ¯_(ツ)_/¯

bertrand-lupart commented 7 years ago

Hello Nicolas,

I was thinking about "Place du Chatelet" because i didn't knew where it was located. But I just figured stations could just move on the map across application restart.

chatelet_good chatelet_bad_1 chatelet_bad_2

bertrand-lupart commented 7 years ago

Same with "Place de Gaulle" de_gaulle_good de_gaulle_bad

bertrand-lupart commented 7 years ago

Have to do some more tests, but it looks like latitude is almost right while longitude may be wrong.

As of the repo not being up to date, could you provide the URL you get the data from? Those provided in Cities.md seem outdated :

Thank you,

n-b commented 7 years ago

Apparently, the current version of the app directly scraps the webpage at https://www.agglo-veloplus.fr/fr/carte/. I’ll try to find a better source.

bertrand-lupart commented 7 years ago

Orléans was totally broken some months ago. Thus, i went in touch with Cykleo which pointed me to https://admin.velossimo.com/services/terminal

Didn't had a look at it at the time, since in the meantime a fixed Bicyclette version showed up in the App store ;)

bertrand-lupart commented 7 years ago

After some more testing, i'm able to trigger the location problem zooming and moving the map. Zooming around and moving the map to the correct location can redraw the station back to the correct place, and eventually misplace another.

I'll manage to provide a screen recording.

Interestingly, when stations are misplaced, they're :

Looks more about a map drawing issue rather than wrong station locations from the source.

bertrand-lupart commented 7 years ago

Re-installed the app, and i can't trigger the problem anymore.

Will tell you if it strikes back.