search

n-riesco / ijavascript

IJavascript is a javascript kernel for the Jupyter notebook
Other
2.19k stars 185 forks source link

Syntax highlighting in Jupyter notebook/lab #212

Closed nathancarter closed 2 years ago

nathancarter commented 4 years ago

I notice that several places where IJavascript is used (for example, the Hello World! notebook) show syntax highlighting in the Jupyter notebook. I couldn't find anything that told me how to ensure that, though. I'm using ijs version 5.2.0 and Jupyter Lab version 1.0.2.

nathancarter commented 4 years ago

Hmm. If I run jupyter notebook instead of jupyter lab, this works fine. So this must be an nbextension that doesn't work in lab, I guess? Maybe this isn't an issue then...?

n-riesco commented 4 years ago

This issue is fixed in Jupyter Lab 1.0.3 (see https://github.com/jupyterlab/jupyterlab/pull/6860 ).

Anyway, I'll mark this issue as a bug in IJavascript, so that I don't forget to fix the kernel_info_reply message that triggers this issue in JupyterLab.

n-riesco commented 2 years ago

Closed in favour of #258