search

n-riesco / ijavascript

IJavascript is a javascript kernel for the Jupyter notebook
Other
2.19k stars 185 forks source link

Failed test on Node.js v0.12 #41

Closed n-riesco closed 9 years ago

n-riesco commented 9 years ago

Some tests fail when running npm run test:4 and npm run test:5 on the latest Docker image for Node.js v0.12:

It looks like a change in the output of thrown exceptions.

Testing execute_request: throw new Error('Hello, World!')
Failed test execute_request: throw new Error('Hello, World!'): Observed = evalmachine.<anonymous>:1
throw new Error('Hello, World!')
      ^
Hello, World!: Expected = Hello, World!
AssertionError: Failed test execute_request: throw new Error('Hello, World!'): Observed = evalmachine.<anonymous>:1
throw new Error('Hello, World!')
      ^
Hello, World!: Expected = Hello, World!
    at Function.MessagingTestEngine.checkMessage (/ijavascript/test/index.js:624:16)
    at /ijavascript/test/index.js:638:29
    at Array.forEach (native)
    at Function.MessagingTestEngine.checkMessage (/ijavascript/test/index.js:635:42)
    at /ijavascript/test/index.js:638:29
    at Array.forEach (native)
    at Function.MessagingTestEngine.checkMessage (/ijavascript/test/index.js:635:42)
    at MessagingTestEngine._runIfPossible (/ijavascript/test/index.js:598:33)
    at MessagingTestEngine.<anonymous> (/ijavascript/test/index.js:431:22)
    at emit (events.js:118:17)
Testing inspect_request: util.inspect
Failed test inspect_request: util.inspect: Observed = evalmachine.<anonymous>:1
util
^
util is not defined: Expected = util is not defined
AssertionError: Failed test inspect_request: util.inspect: Observed = evalmachine.<anonymous>:1
util
^
util is not defined: Expected = util is not defined
    at Function.MessagingTestEngine.checkMessage (/ijavascript/test/index.js:635:16)
    at /ijavascript/test/index.js:652:29
    at Array.forEach (native)
    at Function.MessagingTestEngine.checkMessage (/ijavascript/test/index.js:646:42)
    at /ijavascript/test/index.js:652:29
    at Array.forEach (native)
    at Function.MessagingTestEngine.checkMessage (/ijavascript/test/index.js:646:42)
    at MessagingTestEngine._runIfPossible (/ijavascript/test/index.js:609:33)
    at MessagingTestEngine.<anonymous> (/ijavascript/test/index.js:442:22)
    at emit (events.js:118:17)
n-riesco commented 9 years ago

Opened an issue on the Node.js repository.

n-riesco commented 9 years ago

I've just checked and this issue isn't present in the latest Node.js v4.1.1