Prepend dot to file extension

n-riesco / ijavascript

IJavascript is a javascript kernel for the Jupyter notebook

Other

2.18k stars 187 forks source link

Closed rgbkrk closed 8 years ago

rgbkrk commented 8 years ago

Per the Jupyter Messaging spec, the file extension in a kernel_info_reply needs to include the ..

Noticed this while hacking around with an experimental client.

screenshot 2016-01-17 23 56 59

n-riesco commented 8 years ago

I've merged your PR and released it along other fixes in v5.0.8.

Thanks for fixing this!

PS: Notice that I've created the dev branch with the commits I'm not ready to release.

rgbkrk commented 8 years ago

Whoops, did I target the wrong branch? I used the GitHub UI to edit this.

At any rate, awesome!

n-riesco commented 8 years ago

It's my bad! I shamelessly rebased and renamed the branches. Please, don't tell Linus on me!