n-riesco / ijavascript

IJavascript is a javascript kernel for the Jupyter notebook
Other
2.18k stars 187 forks source link

Logo Thoughts #56

Closed rgbkrk closed 8 years ago

rgbkrk commented 8 years ago

Hey @n-riesco, I know I'm the one that pestered about a logo sometime ago. After having used this for a while, I'd love to see the standard node logo to show similar to how IPython just shows Python's logo:

image

For ijavascript (which is definitely node and not browser javascript), the logo should be the node logo (this one comes from the nodejs github org):

node logo

Scala, R, and many other kernels all use the logo of their respective language. I do think it's ok for the Babel kernel to use:

babel logo

rgbkrk commented 8 years ago

Current header:

screenshot 2016-01-22 11 14 05

Proposed header:

screenshot 2016-01-22 11 14 54

n-riesco commented 8 years ago

I imagine that as long it is clear that the logos identify the language rather than the kernel, it will be OK.

I will look for their licenses.

rgbkrk commented 8 years ago

Here's the Logo page which references the Trademark Guidelines

The particularly relevant bits:

Q: Can I use the Node.js marks? A: Yes, in accordance with these guidelines.

In the project README we probably have to include:

Node.js is a trademark of Joyent, Inc. and is used with its permission. We are not endorsed by or affiliated with Joyent.

We also can not sell items using the Node.js logo.

This is open source software designed to help people interact with node, learn, do research, and develop software. It would be pretty crazy for us to run into problems here.

rgbkrk commented 8 years ago

If you're ok with it, I'm happy to submit a PR updating the README and the bundled logo.

rgbkrk commented 8 years ago

By the way, I don't mean to overwrite the main IJavascript logo, only the language icon shown in the corner of a notebook.

n-riesco commented 8 years ago

OK.

You'd need to edit the logo filename here:

https://github.com/n-riesco/ijavascript/blob/master/bin/ijavascript.js#L297

and here:

https://github.com/n-riesco/ijavascript/blob/master/bin/ijavascript.js#L299

I would also add a LICENSE file to the images folder listing the filenames of Joyent's files and providing a link to Joyent's trademark guidelines.

rgbkrk commented 8 years ago

Sorry that took me a bit to get done. It's in #57.