Closed mandarvaze closed 8 years ago
I had not read the CONTRIBUTING document before this PR, and thus I have did not create an issue (The change is minor) and have not updated AUTHORS file. Feel free to reject this PR, I will then make these changes, and reissue the PR.
Good changes! I've been having people install one of the packages that includes zmq
somehow, which would include pip install notebook
.
I tend not to encourage people to use the pip3
, relying on their default version of pip
instead (some have python
as python 3).
pip install -U jupyter
should also work, as mentioned on the jupyter
read the docs page.
But I have not used it myself, is all.
I'm 99% sure "pip" (python2) version will also install the dependency automatically.
Do you want me to send new PR, changing pip3
to pip
? (I will also create an issue, and update AUTHORs page, while I am at it.)
Ah, cool.
If this was a repo I was maintaining, I'd just have you push a new commit changing the instruction. You can squash down to one commit if @n-riesco thinks otherwise.
@mandarvaze I agree with Kyle. I'd rather recommend pip
.
And yes, please, I ask all the contributors to add their name to the AUTHORS file.
I wouldn't open another commit, I would simply:
git commit -a --amend
git push -f
But I don't really mind.
Done.
I have updated patch-1
branch with the following changes :
pip
instead of pip3
@mandarvaze Thank you!
pip3 install -U jupyter
installs the other dependencies likejsonschema, pyzmq, jinja2
etc. automatically I've successfully installed ijavascript on OSX (El Capitan) using these instructions.