Fix loading package.json to find version

n-riesco / ijavascript

IJavascript is a javascript kernel for the Jupyter notebook

Other

2.19k stars 185 forks source link

Fix loading package.json to find version #77

Closed int3h closed 8 years ago

int3h commented 8 years ago

In lib/kernel.js, line 183 tries to load ijavascript's package.json file to find the current version number. However, if $PWD isn't the ijavascript module folder, this will fail with a "file not found" error.

This commit changes that line so that it tries to load __dirname/../package.json (using the path.join() utility for cross-platform portability).

n-riesco commented 8 years ago

Thank you for the contribution!

I've tested it and it works for me. Before I merge it, please, could you:

[x] update similarly this line in the test script;
[x] add your name to the list of authors. I ask contributors to do so, to confirm their consent to distributing their contributions under the LICENSE terms.

Again, thanks for taking the time to fix this bug.

int3h commented 8 years ago

@n-riesco done!

n-riesco commented 8 years ago

@int3h I went ahead and released this PR as IJavascript@5.0.14. Thanks for contributing!