search

n-riesco / ijavascript

IJavascript is a javascript kernel for the Jupyter notebook
Other
2.18k stars 187 forks source link

Updated Readme to remove `sudo npm` #86

Closed brendannee closed 7 years ago

n-riesco commented 7 years ago

In Ubuntu (unless configured otherwise) npm install -g ijavascript requires admin rights.

Or am I missing something?

BTW, I've been preparing an update of the documentation. You can find it in the dev branch.

rgbkrk commented 7 years ago

For anyone using nvm or other local node environments we don't use sudo whatsoever. Same thing applies to when used in a Docker container. A lot of newer node users will end up using nvm, read instructions like these that recommend sudo, then wonder why things are broken/not working for them.

I tend not to include sudo in instructions because of this. For users that need it, they can choose to prepend it.

n-riesco commented 7 years ago

@rgbkrk Rather than breaking the instructions for Ubuntu users, we should add a section for nvm and docker users (though, I don't follow why sudo wouldn't work for nvm users).

rgbkrk commented 7 years ago

I don't follow why sudo wouldn't work for nvm users

sudo will be the system environment rather than their nvm environment (default or some configured install).

n-riesco commented 7 years ago

Closed in favour of https://github.com/n-riesco/ijavascript/commit/e4801047ae0bb53ca72a8f421271d8427cd09990