search

n-riesco / jp-babel

jp-babel is a babel kernel for the Jupyter notebook
Other
86 stars 16 forks source link

fix issue with install error #25

Closed huynhnguyen closed 3 years ago

huynhnguyen commented 4 years ago

Hi @n-riesco,

Really enjoy your work, I would like to commit my fix for install error, I also notice the minimal node version should be 8 not 6. As I develop some new features for my specific use case from your library and will love to hear from you for collaboration.

n-riesco commented 4 years ago

Hi @n-riesco,

Hi,

[...] I would like to commit my fix for install error

What install error? Could you open an issue with the instructions to reproduce the error, please?

[...] I also notice the minimal node version should be 8 not 6.

My understanding of https://babeljs.io/docs/en/v7-migration is that Babel v7 hasn't dropped support for node v6.

[...]

I've just noticed this PR seems to be based on an old commit (April, 2018) before jp-babel was upgraded to Babel v7. Please, use the latest version of jp-babel, I suspect it'll solve your install error.