Implement is_complete_request to add support for multiline editing

n-riesco / jp-kernel

Generic Node.js kernel for the Jupyter notebook

Other

21 stars 15 forks source link

Implement is_complete_request to add support for multiline editing #1

Closed fdintino closed 7 years ago

fdintino commented 7 years ago

A big feature of the IPython v5.0 messaging protocol that is missing in jp-kernel is the is_complete_request call, which allows for multi-line editing. This PR adds support for it.

n-riesco commented 7 years ago

Thank you for contributing!

I'd like to merge this PR. Please, could you:

[ ] address the comments I wrote above;
[ ] add your name to the AUTHORS file (I ask contributors to do so, to confirm their consent to distributing their contributions under the LICENSE terms).

fdintino commented 7 years ago

Gladly. Going forward I'll incorporate your feedback in separate commits (to preserve the line-comment conversation), and once everything looks good to you I can rebase it into a single clean commit.

For a bit of context, I actually use these kernels with jupyter console, not jupyter notebook (which, as far as I can tell, does not need to support the is_complete_reply message).

n-riesco commented 7 years ago

There is an issue opened in IJavascript that asks about using IJavascript in the Jupyter console.

This issue has made me think that IJavascript should provide to CLI commands:

ijs to open the Jupyter notebook
ijs-console to open the Jupyter console.