Support message handler additions/overrides on Kernel config - Githubissues

n-riesco / jp-kernel

Generic Node.js kernel for the Jupyter notebook

Other

21 stars 15 forks source link

Support message handler additions/overrides on Kernel config #2

Closed fdintino closed 7 years ago

fdintino commented 7 years ago

This is an alternative proposal to PR #1, based on our conversation there.

It is intended to support n-riesco/ijavascript#81, which adds an "is_complete_request" message handler.

n-riesco commented 7 years ago

@fdintino I'm sorry to delay this for so long. Now, I only have time to explain this briefly, but I'll explain in more detail when I find more time:

PR #1 implements is_complete_request by touching only jp-kernel
PR #2 helps implement is_complete_request but requires changes in jp-kernel and ijavascript:
- this is unnecessary (this can be done by touching ijavascript only)
- the changes in jp-kernel are incompatible with the changes I already mentioned I'm planning.

Again sorry for the delay in coming back to you. I'll explain everything better in https://github.com/n-riesco/ijavascript/pull/81 (not today, though).