search

n-t-roff / heirloom-doctools

The Heirloom Documentation Tools: troff, nroff, and related utilities
http://n-t-roff.github.io/heirloom/doctools.html
Other
127 stars 23 forks source link

Fixes #90: Kerning adjustment being performed on device control function \X'string' #91

Closed mircea3 closed 4 years ago

mircea3 commented 4 years ago

This changes one line (plus some white space). The before/after result can be seen in pdf files attached to issue #90.

Alhadis commented 4 years ago

plus some white space

Was that accidental? What editor are you using?

mircea3 commented 4 years ago

I use emacs. My personal preference is for the editor to strip all trailing space when saving, making sure new files are clean, and older files gradually becoming cleaner. However, that is a personal preference; if others prefer the trailing spaces I could put them back (for this project).

Alhadis commented 4 years ago

It's not about preference, it's about keeping revision history clean and atomic. This sort of cleanup can always be done in a later PR, if you're so inclined (and I believe @n-t-roff may wish to add an .editorconfig or .dir.locals.el file or something to prevent bikesheddy stuff like this arising in future... 😉)

n-t-roff commented 4 years ago

I have to agree to @Alhadis , no unnecessary changes please. @Alhadis : Using .editorconfig is a good hint.