fix: rework client counters on the relay

n0-computer / iroh

peer-2-peer that just works

https://iroh.computer

Apache License 2.0

2.61k stars 165 forks source link

fix: rework client counters on the relay #2916

Closed Arqu closed 2 weeks ago

Arqu commented 2 weeks ago

Description

This substitutes the current "basic" logic in the relay unique node counters with a more durable (redis) store and provides a globally unique setup. Otherwise it should have all the same characteristics as before.

Breaking Changes

Notes & open questions

Change checklist

[ ] Self-review.
[ ] Documentation updates following the style guide, if relevant.
[ ] Tests if relevant.
[ ] All breaking changes documented.

github-actions[bot] commented 2 weeks ago

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2916/docs/iroh/

Last updated: 2024-11-11T11:01:14Z

github-actions[bot] commented 2 weeks ago

Netsim report & logs for this PR have been generated and is available at: LOGS This report will remain available for 3 days.

Last updated for commit: 6588f3f

dignifiedquire commented 2 weeks ago

this should be fully optional, we don’t want to depend on redis by default

matheus23 commented 2 weeks ago

If I may paraphrase the two problems this PR intends to solve: False "positives" on unique nodes because of the uniqueness only being calculated

per-relay, not in one memory space across all relays
in-memory, so not persisted between restarts.

Arqu commented 2 weeks ago

During some side channel discussion we decided to shelf this for a later point in time.