refactor(iroh-relay): improve overall server structure

[dignifiedquire]

Description

Trying to make the server relay code a little less crazy.

• moves stun_metrics from server to server::metrics which is a more appropriate place for this.
• moves ServerMessage (the messages the server actor receives) from server to server::actor
• removes ServerMessage::Shutdown since there was already a CancellationToken, thus reducing the ways to shutdown to simply one.
• removes the boolean field ServerActorTask::closed. We don't need this is we correctly handle shutdown on drop.
• Makes write_timeout not an option. This was never None.
• move handling receiving messages in the server actor loop to its own function to keep code tidy.
• reduces unnecessary Arcs and cloning by inlining ClientConnHandler in the RelayServer
• inline ServerState in RelayServer. This was just used to serve / spawn the server.
• reduces detached spawned tasks by always awaiting on Client shutdown.
• inline where possible to simplify
• reduce types
• some renaming of types, to make them easier to understand

Breaking Changes

• iroh-relay now uses NodeGone instead of PeerGone in some enums, but iroh-relay is unpublished, so technically not a breaking change

[github-actions[bot]]

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2922/docs/iroh/

Last updated: 2024-11-13T19:59:12Z

[github-actions[bot]]

Netsim report & logs for this PR have been generated and is available at: LOGS This report will remain available for 3 days.

Last updated for commit: f849659

[divagant-martian]

I was mid review, but happy enough with things. While reviewing I updated the description trying to enumerate the changes. Whatever complains I had can be done in another PR :ok_hand:

[dignifiedquire]

While reviewing I updated the description trying to enumerate the changes

thank you!

I was mid review, but happy enough with things.

oh no, I am sorry, I didn't realize, I will happily make another PR with your suggestions