No error if file got deleted on the sender side

n0-computer / sendme

A tool to send files and directories, based on iroh

Other

96 stars 6 forks source link

No error if file got deleted on the sender side #9

Closed link2xt closed 10 months ago

link2xt commented 10 months ago

I downloaded sendme 0.2.3 and ran sendme provide screenshot.jpg.

Then when I removed the file and tried to get it, I got no error, simply nothing is downloaded silently.

Then I recreated empty file with touch screenshot.jpg. Then receiver side started to show "provide side no longer has part of a file" when attempting to download. I removed the file again and ran sendme get again - it silently does not receive anything.

rklaehn commented 10 months ago

Thanks for the test. This is a bug, but nothing major. You get an error. It is even a very appropriate error, NotFound.

But currently we don't print that but just abort with a non 0 exit code. The fix is to just print something when getting this error. How is this:

rklaehn commented 10 months ago

Should be fixed with the latest release