n00mkrad / cupscale

Image Upscaling GUI based on ESRGAN
MIT License
2.14k stars 113 forks source link

Fixed FFmpeg.cs #131

Open H41Ri0 opened 2 years ago

H41Ri0 commented 2 years ago

Fixed a bug that prevented ffmpeg from exiting with subtitled mkv files

n00mkrad commented 2 years ago

Seems like a bad idea, this will kill ALL running ffmpeg instances on the current users.

Can you show me how to reproduce this issue?

H41Ri0 commented 2 years ago

Indeed. You are right.
This occurred with an mkv file with the following configuration
log.txt Upscaling a file with this configuration will cause Cupscale.exe to stop working because ffmpeg will not exit. (Terminating ffmpeg in the Task Manager will restart the operation.)