n00mkrad / cupscale

Image Upscaling GUI based on ESRGAN
MIT License
2.15k stars 113 forks source link

Disabled suffix causes new file to be created with the extension shown twice at the end of the name #63

Open RocketRobz opened 3 years ago

RocketRobz commented 3 years ago

When I enable Yes - Don't add suffix, Overwrite If Extension Matches, and then do an upscale process, a new file is created with the extension shown twice at the end of the filename.

Ex. texture.png should be overwritten, but a new file called texture.png.png is created instead.

n00mkrad commented 3 years ago

Can't reproduce this on the latest code...

RocketRobz commented 3 years ago

Still happens on 1.39.0. For further context, this happens with both PNG and Same as source set as output format, and occurs with any filename, such as tex1_128x128_5A7AFE0A68F7494A_2.png or just simply test.png.

RocketRobz commented 3 years ago

Hmm, it seems to be caused by setting AI Network to ESRGAN (NCNN). With RealESRGAN (NCNN), the filename is proper, and cannot be reproduced.

n00mkrad commented 3 years ago

That's pretty odd, I'll take a look at it.