search

n00mkrad / cupscale

Image Upscaling GUI based on ESRGAN
MIT License
2.15k stars 113 forks source link

Pytorch suggests reducing tile size on one system but not another one #91

Open 2haloes opened 2 years ago

2haloes commented 2 years ago

Hello,

I have encountered a strange issue and if this is something that should be raised on the script then I can do that.

When using my computer with an Nvidia 3080 (10GB of VRAM), I can occasionally get an error that the tile size needs to be reduced but there is no option for this to be changed (and it appears that the script doesn't support a manual tile size now)

However, when using my laptop with an Nvidia 3080 (16GB of VRAM) I can upscale any image without any restrictions.

While I can guess why this could be happening (10GB is pretty weird for a RAM size), it's still an issue as I'm more typically using this on my computer and I need to use my laptop for work

Katzenwerfer commented 2 years ago

afaik, changing tile size is only a supported feature for the ncnn implementations, but it still shouldn't error out since the tile size is pretty much automatic. You could try to restart the app or your computer (that always tends to work for me), but there probably isn't much to do there.

2haloes commented 2 years ago

I might have to report an issue with the script then as I tried right after a reboot before loading anything else up and I still get the same error

Screenshot of the error message attached just in case image

Katzenwerfer commented 2 years ago

Maybe try running a single model instead of multiple ones (chained). I'm honestly pretty sure it won't change anything, but I guess it's worth trying.

2haloes commented 2 years ago

I've found that it is 100% the script doing this, not sure if I should keep this open until it's resolved in the script

Even running the script with a single model causes this issue unfortunately

n00mkrad commented 2 years ago

Are you sure you want to upscale an 1080p image 16x? That's just ridiculous.