n00mkrad / flowframes

Flowframes Windows GUI for video interpolation using DAIN (NCNN) or RIFE (CUDA/NCNN)
GNU General Public License v3.0
1.47k stars 114 forks source link

Unrecognized arguments in prompt field #175

Closed qwitriy closed 2 years ago

qwitriy commented 2 years ago

Describe the bug Prompt passes to dream.py without escaping of arguments. In result, field "Prompt" can be used to set dream.py's optional arguments and possible break processing.

To Reproduce Steps to reproduce the behavior:

  1. Enter text, which includes any valid or invalid dream.py's argument into Prompt field of the GUI. e.x: "-h", "-asd", "- asd"
  2. Click on 'Generate!'
  3. Wait for "Done!" in log field of bottom right in the window (or in the sessionlog.txt).
  4. Invalid aruments will leave error message "dream.py: error: unrecognized arguments:", valid arguments will either apply to processing or render help information into log.

Expected behavior It could be either:

  1. No errors and everything works fine (ha-ha sorry)
  2. Showing proper error message in the log field.
  3. Processing as if no arguments are expected in Prompt field and all the text in it assumed as prompt

Screenshots image image

Desktop (please complete the following information):

qwitriy commented 2 years ago

I'm sorry to put this into wrong repository