search

n00mkrad / flowframes

Flowframes Windows GUI for video interpolation using DAIN (NCNN) or RIFE (CUDA/NCNN)
GNU General Public License v3.0
1.46k stars 114 forks source link

Odd behavior when passing -factor as command line argument #237

Open Michaelvirga opened 1 year ago

Michaelvirga commented 1 year ago

I'm observing very inconsistent results when passing different values for -factor in the command line argument.

C:\Users\xxx>"C:\Users\xxx\AppData\Local\Flowframes\Flowframes.exe" "C:\Users\xxx\Image Environments\video_15_fps.mp4" -factor=8 -start -quit-when-done -ai=0 -output-mode=0 -model=0

When passing factor=8, it will actually set the x factor to 4. When I pass factor=4, it will set the x factor to 3. When I pass factor=3, it will set x to 2. When I pass factor as 6, it sets x factor to 2. Is there any consistency to this or intention behind why it's setting the x factor to different values other than what was actually passed in factor?

Full observation list:

2 = 2 3 = 2 4 = 3 5 = 2 6 = 2 7 = 2 8 = 4 9 = 2 10 = 2

Is it based off FPS or something else which I'm missing?

Basically I am going off of this documentation (only that exists) on how to pass CLI arguments: https://github.com/n00mkrad/flowframes/issues/67

Sorry if this is not officially supported, it's just so close to being a massive efficiency increase in my workflow, it would be great if the CLI was a bit more robust and documented! Really powerful tool.

n00mkrad commented 1 year ago

The factor is index-based I think and will not work properly with custom numbers, I'll need to update the CLI code. I'll take a look soon.

Michaelvirga commented 1 year ago

@n00mkrad Much appreciated, I can get by with 4x being the max (passing 8), but for higher frame interpolation would be cool! No rush on it either.

jamesonknutson commented 1 year ago

The factor is index-based I think and will not work properly with custom numbers, I'll need to update the CLI code. I'll take a look soon.

Could it be that you're parsing the factor argument as a float? All of the other index-based arguments seem to be parsed as integers (see line 167):

https://github.com/n00mkrad/flowframes/blob/693a2471d1e9f6362f0964ed33ddfa46f6f2a2c1/Code/Forms/Main/Form1.cs#L160-L179

neilthefrobot commented 5 months ago

This is still an issue for me =( No matter what factor I use it does 2x