n00mkrad / flowframes

Flowframes Windows GUI for video interpolation using DAIN (NCNN) or RIFE (CUDA/NCNN)
GNU General Public License v3.0
1.46k stars 114 forks source link

Video on NCNN flickers on dark tones #272

Open Astalavista1655 opened 1 year ago

Astalavista1655 commented 1 year ago

Hello. I updated the monitor, now I have good black color reproduction, but now compression artifacts are visible. It’s different for different AIs (CUDA and NCNN/VS). The first type of artifact in the screenshots (the brightness is of course increased): an artifact in the form of flickering throughout the video, clearly visible in the black bars, and of course in the video itself, such flickering appears with the following settings: RIFE (NCNN/VS)/h264 NVENC/Very High. The second type of artifact complements the first: now a tile appears along with the flickering (I changed the tile sizes in the settings, but nothing changed), this is with the same settings, but on h265 NVENC. NCNN without VS simply doesn't work. Finally, these artifacts are not present on RIFE (CUDA) on h264 NVENC and on h265 NVENC. What happens, the whole problem is in NCNN? What can be done to eliminate such artifacts, because there is no point in CUDA, because it can't work with a factor of 2.5, and besides, it's slower. The problems are the same on different video card drivers (3060 RTX) ART2 ART ART1

This is exactly flickering, 4 frames with artifacts, 1 frame without artifacts

There are no artifacts on CUDA CUDA mp4_snapshot_00 05 956

https://github.com/n00mkrad/flowframes/assets/136258017/63319498-55cb-4dce-adf9-4f01de08f9ef

https://github.com/n00mkrad/flowframes/assets/136258017/926034e2-015a-4b93-a5b8-ce769a746377

jensdraht1999 commented 1 year ago

Hello,

you might test out the same video with "SETTINGS->INTERPOLATION->FIX SCENE CHANGES (CUTS)" and set it to OFF and try again.

Because the only software side of difference between those two are just, than scene changes are blended in via ImageMagick, otherwise, there is not difference between those implementations as far as I can see.

Astalavista1655 commented 1 year ago

I never use FIX SCENE CHANGES, so the problem is still relevant

Astalavista1655 commented 1 year ago

Hello,

you might test out the same video with "SETTINGS->INTERPOLATION->FIX SCENE CHANGES (CUTS)" and set it to OFF and try again.

Because the only software side of difference between those two are just, than scene changes are blended in via ImageMagick, otherwise, there is not difference between those implementations as far as I can see.

In general, the problem is with VapourSynth, there are no artifacts on NCNN without VS